search

RIOT-OS / riotdocker

Dockerfiles for creating build environment for building RIOT projects.
34 stars 45 forks source link

murdock-worker: bump git-cache-rs to 0.1.5 #244

Closed kaspar030 closed 9 months ago

kaspar030 commented 9 months ago

When the initial git cache clone would have a commit specified (--commit HASH), and would trigger the initial clone into the cache directory, the final "checkout HASH" was skipped.

This caused the first dwq worker thread to checkout a branch to fail every job with ./.murdock: not found.

https://github.com/kaspar030/git-cache-rs/compare/0.1.3...0.1.5

chrysn commented 9 months ago

Please rebase onto https://github.com/RIOT-OS/riotdocker/pull/246 (or master once that is in), that should make the problem go away.

kaspar030 commented 9 months ago

huh, this was rebased, it still shows fatal error: 'preprocessor_successor.h' file not found? link

chrysn commented 9 months ago

/me facepalms

The 2024.01 release did not yet get the riot-sys fix.

On the "how do we make sure this doesn't happen again" side, I've added a check point to the release check list that'll flag when there are pending commits on riot-sys/-wrappers.

On the "what do we do now" side ... can we backport 002cd42e26e7fbc3140e9d7aa5a1788bfa9f70f9? Even if we don't do a point release (we rarely do), this makes sure the fix winds up on the branch that gets pulled. (I'd PR it myself, but the backport script doesn't work for people whose RIOT clone is not in their user repo).

kaspar030 commented 9 months ago

can we backport 002cd42e26e7fbc3140e9d7aa5a1788bfa9f70f9?

I guess so.

kaspar030 commented 9 months ago

I'd PR it myself, but the backport script doesn't work for people whose RIOT clone is not in their user repo

so which PR is that?

chrysn commented 9 months ago

https://github.com/RIOT-OS/RIOT/pull/20303

MrKevinWeiss commented 9 months ago

Or should it just be the one commit?

MrKevinWeiss commented 9 months ago

Even if we don't do a point release (we rarely do), this makes sure the fix winds up on the branch that gets pulled. (I'd PR it myself, but the backport script doesn't work for people whose RIOT clone is not in their user repo).

I would probably do a point release, maybe after a week if everything is stable.

kaspar030 commented 9 months ago

While you're here - would you give this an ACK? It's been tested quite a bit on ci-staging.riot-os.org.