search

RIOT-OS / rust-riot-wrappers

The `riot-wrappers` crate, which enables high-level access to RIOT from the Rust programming language
13 stars 10 forks source link

GBA problems #100

Open chrysn opened 2 months ago

chrysn commented 2 months ago

PR https://github.com/RIOT-OS/rust-riot-wrappers/pull/89 was auto-closed because it was merged as part of https://github.com/RIOT-OS/rust-riot-wrappers/pull/90 but then some of it was reverted: In particular, some portable-atomic backend needs to be enabled (and we don't have that yet)

Just enabling portable-atomic-unsafe-assume-single-core does not work because it breaks builds for native; some notes are in #89 on how to continue.

CC'ing @Teufelchen1 who opened the original PR.

chrysn commented 2 months ago

Relatedly, tests/ztimer-async directly enables critical-section on portable-atomic. Could that be part of a solution here?

Teufelchen1 commented 1 month ago

Could you link that tests/ztimer-async section? I think I misunderstood since I can't find it.

chrysn commented 1 month ago

https://github.com/RIOT-OS/rust-riot-wrappers/blob/e07288f76239b4599a7cbf2223ce34ff8dcd6e2c/tests/ztimer-async/Cargo.toml#L24 and the provide_critical_section_1_0 a few lines above.

(On the long run, RIOT's modules should enable all these with the per-board correct settings, but what is in there should AIU work everywhere now, in which case those settings should be enabled more widely)