codecov-commenter
commented
1 year ago Codecov Report
Base: 59.11% // Head: 59.14% // Increases project coverage by +0.03% :tada:
Coverage data is based on head (
734ce78) compared to base (350b8f8). Patch coverage: 68.51% of modified lines in pull request are covered.
:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
Additional details and impacted files
```diff @@ Coverage Diff @@ ## main #155 +/- ## ========================================== + Coverage 59.11% 59.14% +0.03% ========================================== Files 31 32 +1 Lines 2101 2235 +134 ========================================== + Hits 1242 1322 +80 - Misses 859 913 +54 ``` | [Impacted Files](https://codecov.io/gh/RIP-Comm/clementine/pull/155?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None) | Coverage Δ | | |---|---|---| | [emu/src/cpu/opcode.rs](https://codecov.io/gh/RIP-Comm/clementine/pull/155?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-ZW11L3NyYy9jcHUvb3Bjb2RlLnJz) | `88.05% <ø> (+1.69%)` | :arrow_up: | | [emu/src/memory/internal\_memory.rs](https://codecov.io/gh/RIP-Comm/clementine/pull/155?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-ZW11L3NyYy9tZW1vcnkvaW50ZXJuYWxfbWVtb3J5LnJz) | `95.94% <ø> (ø)` | | | [logger/src/lib.rs](https://codecov.io/gh/RIP-Comm/clementine/pull/155?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-bG9nZ2VyL3NyYy9saWIucnM=) | `85.71% <ø> (ø)` | | | [ui/src/app.rs](https://codecov.io/gh/RIP-Comm/clementine/pull/155?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-dWkvc3JjL2FwcC5ycw==) | `0.00% <0.00%> (ø)` | | | [ui/src/disassembler.rs](https://codecov.io/gh/RIP-Comm/clementine/pull/155?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-dWkvc3JjL2Rpc2Fzc2VtYmxlci5ycw==) | `0.00% <0.00%> (ø)` | | | [emu/src/cpu/condition.rs](https://codecov.io/gh/RIP-Comm/clementine/pull/155?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-ZW11L3NyYy9jcHUvY29uZGl0aW9uLnJz) | `25.00% <22.22%> (+2.77%)` | :arrow_up: | | [emu/src/memory/timer\_registers.rs](https://codecov.io/gh/RIP-Comm/clementine/pull/155?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-ZW11L3NyYy9tZW1vcnkvdGltZXJfcmVnaXN0ZXJzLnJz) | `51.51% <27.27%> (ø)` | | | [emu/src/cpu/arm7tdmi.rs](https://codecov.io/gh/RIP-Comm/clementine/pull/155?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-ZW11L3NyYy9jcHUvYXJtN3RkbWkucnM=) | `81.17% <75.00%> (+0.25%)` | :arrow_up: | | [emu/src/cpu/alu\_instruction.rs](https://codecov.io/gh/RIP-Comm/clementine/pull/155?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-ZW11L3NyYy9jcHUvYWx1X2luc3RydWN0aW9uLnJz) | `62.92% <79.16%> (+10.61%)` | :arrow_up: | | [emu/src/cpu/instruction.rs](https://codecov.io/gh/RIP-Comm/clementine/pull/155?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-ZW11L3NyYy9jcHUvaW5zdHJ1Y3Rpb24ucnM=) | `83.10% <85.07%> (+0.75%)` | :arrow_up: | | ... and [9 more](https://codecov.io/gh/RIP-Comm/clementine/pull/155?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None) | | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None):umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
This PR prepare the code for supporting the ASM widget. Now half of work we previous did in same function of execution a specific instruction is moved while decoding, this because we can use those information for printing all parameters in a widgets.
Also the tests are very complete right now because we can test many different condition in a clear way.
https://user-images.githubusercontent.com/41150432/218267824-02f16fcb-7af7-4c6f-8916-9864ee409280.mov