RIP-Comm / clementine

Gameboy Advance emulator.
MIT License
49 stars 13 forks source link

Fix thumb ops #156

Closed AlessioC31 closed 1 year ago

AlessioC31 commented 1 year ago

Since we're using the sign-exteding feature in many places maybe we should put it somewhere? I've tried implementing in Bits but it's a bit of a mess since we would need TryFrom/Into 128 or something like that and it was not working, maybe I can try again, I tried couple of weeks ago

codecov-commenter commented 1 year ago

Codecov Report

Base: 56.32% // Head: 56.26% // Decreases project coverage by -0.06% :warning:

Coverage data is based on head (3110dad) compared to base (967ce13). Patch coverage: 42.85% of modified lines in pull request are covered.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #156 +/- ## ========================================== - Coverage 56.32% 56.26% -0.07% ========================================== Files 32 32 Lines 2008 2012 +4 ========================================== + Hits 1131 1132 +1 - Misses 877 880 +3 ``` | [Impacted Files](https://codecov.io/gh/RIP-Comm/clementine/pull/156?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None) | Coverage Δ | | |---|---|---| | [emu/src/cpu/arm7tdmi.rs](https://codecov.io/gh/RIP-Comm/clementine/pull/156/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-ZW11L3NyYy9jcHUvYXJtN3RkbWkucnM=) | `76.78% <42.85%> (-0.42%)` | :arrow_down: | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.