search

RIP-Comm / clementine

Gameboy Advance emulator.
MIT License
49 stars 13 forks source link

UI: Add `breakpoints` window #164

Closed AlessioC31 closed 1 year ago

AlessioC31 commented 1 year ago

Added breakpoints functionality to the UI

codecov-commenter commented 1 year ago

Codecov Report

Base: 58.44% // Head: 57.72% // Decreases project coverage by -0.72% :warning:

Coverage data is based on head (640e653) compared to base (942fa39). Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #164 +/- ## ========================================== - Coverage 58.44% 57.72% -0.73% ========================================== Files 32 32 Lines 2084 2110 +26 ========================================== Hits 1218 1218 - Misses 866 892 +26 ``` | [Impacted Files](https://codecov.io/gh/RIP-Comm/clementine/pull/164?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None) | Coverage Δ | | |---|---|---| | [ui/src/cpu\_inspector.rs](https://codecov.io/gh/RIP-Comm/clementine/pull/164/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-dWkvc3JjL2NwdV9pbnNwZWN0b3IucnM=) | `0.00% <0.00%> (ø)` | | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

guerinoni commented 1 year ago

Nice, but I would change something here...

  1. Let's create an "handle" panel for start/stop/pause + breakpoints in order to keep separated from cpu register...
  2. In CPU register we see value non in hex but adding a breakpoint it will took as hex
  3. Not sure to make the check of register there but maybe we can call "pause" functionality for keeping more consistent? Or request pause when we are at that address??
  4. Is not very clear that address is referring to PC, maybe we could add a breakpoint also for memory address... (next feature :P ) just make more clear
AlessioC31 commented 1 year ago

Nice, but I would change something here...

  1. Let's create an "handle" panel for start/stop/pause + breakpoints in order to keep separated from cpu register...
  2. In CPU register we see value non in hex but adding a breakpoint it will took as hex
  3. Not sure to make the check of register there but maybe we can call "pause" functionality for keeping more consistent? Or request pause when we are at that address??
  4. Is not very clear that address is referring to PC, maybe we could add a breakpoint also for memory address... (next feature :P ) just make more clear

1) Good idea 2) That's true I will solve that maybe showing register values in hex or giving the choice to the user 3) Isn't it what it's currently doing? When the address is reached I change the bool variable which is tecnically what the pause button does 4) I only knew about breakpoints in code execution. What are the breakpoints in the memory?

guerinoni commented 1 year ago

Not sure if is a "standard" breakpoint but it can be useful stop when a certain memory address is read or write 🤷🏻