search

RIP-Comm / clementine

Gameboy Advance emulator.
MIT License
49 stars 13 forks source link

`ArmModeInstruction::DataProcessing` has redundancy in the fields #168

Open AlessioC31 opened 1 year ago

AlessioC31 commented 1 year ago 
pub enum ArmModeInstruction {
    DataProcessing {
        condition: Condition,
        alu_instruction: ArmModeAluInstruction,
        set_conditions: bool,
        op_kind: OperandKind,
        rn: u32,
        destination: u32,
        op2: AluSecondOperandInfo,
    },
...

We can remove op_kind since it encodes the information about whether the second op is register/immediate, but we already have this information in the op2 field