RIP-Comm / clementine

Gameboy Advance emulator.
MIT License
49 stars 13 forks source link

DMA: Add unued chunk of memory because BIOS wirte on those #173

Closed guerinoni closed 1 year ago

guerinoni commented 1 year ago

Signed-off-by: Federico Guerinoni guerinoni.federico@gmail.com

codecov-commenter commented 1 year ago

Codecov Report

Base: 58.05% // Head: 57.65% // Decreases project coverage by -0.40% :warning:

Coverage data is based on head (c9ff9c2) compared to base (0731163). Patch coverage: 17.24% of modified lines in pull request are covered.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #173 +/- ## ========================================== - Coverage 58.05% 57.65% -0.40% ========================================== Files 34 34 Lines 2308 2324 +16 ========================================== Hits 1340 1340 - Misses 968 984 +16 ``` | [Impacted Files](https://codecov.io/gh/RIP-Comm/clementine/pull/173?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None) | Coverage Δ | | |---|---|---| | [emu/src/memory/lcd\_registers.rs](https://codecov.io/gh/RIP-Comm/clementine/pull/173?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-ZW11L3NyYy9tZW1vcnkvbGNkX3JlZ2lzdGVycy5ycw==) | `22.93% <ø> (ø)` | | | [emu/src/memory/timer\_registers.rs](https://codecov.io/gh/RIP-Comm/clementine/pull/173?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-ZW11L3NyYy9tZW1vcnkvdGltZXJfcmVnaXN0ZXJzLnJz) | `34.69% <0.00%> (-16.83%)` | :arrow_down: | | [emu/src/memory/dma.rs](https://codecov.io/gh/RIP-Comm/clementine/pull/173?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-ZW11L3NyYy9tZW1vcnkvZG1hLnJz) | `16.66% <14.28%> (ø)` | | | [emu/src/memory/internal\_memory.rs](https://codecov.io/gh/RIP-Comm/clementine/pull/173?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-ZW11L3NyYy9tZW1vcnkvaW50ZXJuYWxfbWVtb3J5LnJz) | `96.10% <100.00%> (ø)` | | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.