RIP-Comm / clementine

Gameboy Advance emulator.
MIT License
49 stars 13 forks source link

THUMB: Fix `UncondBranch` #179

Closed AlessioC31 closed 1 year ago

AlessioC31 commented 1 year ago

We were not sign extending the offset correctly

codecov-commenter commented 1 year ago

Codecov Report

Patch coverage: 100.00% and no project coverage change

Comparison is base (f6cfea6) 55.09% compared to head (7c52015) 55.09%.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #179 +/- ## ======================================= Coverage 55.09% 55.09% ======================================= Files 37 37 Lines 2521 2521 ======================================= Hits 1389 1389 Misses 1132 1132 ``` | [Impacted Files](https://codecov.io/gh/RIP-Comm/clementine/pull/179?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None) | Coverage Δ | | |---|---|---| | [emu/src/cpu/arm7tdmi.rs](https://codecov.io/gh/RIP-Comm/clementine/pull/179?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-ZW11L3NyYy9jcHUvYXJtN3RkbWkucnM=) | `81.06% <100.00%> (ø)` | | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.