search

RIP-Comm / clementine

Gameboy Advance emulator.
MIT License
48 stars 13 forks source link

CPU: Add program_counter to disassembler #186

Closed RyanPaulGannon closed 1 year ago

RyanPaulGannon commented 1 year ago

Added the Program Counter (R15) to the disassembler window to help with debugging.

There is an error where the Program Counter disappears after so many steps ...

guerinoni commented 1 year ago

I see the problem... Because we populate ASM buffer here and here But this is only the buffer that we print in UI. I would suggest to check also here if can be a better point or just add same logic for both mode. :)

RyanPaulGannon commented 1 year ago

Added the same code to the execute_thumb() function. Work around for now whilst we debug ...

codecov-commenter commented 1 year ago

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.11 :tada:

Comparison is base (59e2902) 56.83% compared to head (a77fa9b) 56.94%.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #186 +/- ## ========================================== + Coverage 56.83% 56.94% +0.11% ========================================== Files 37 37 Lines 2729 2736 +7 ========================================== + Hits 1551 1558 +7 Misses 1178 1178 ``` | [Impacted Files](https://app.codecov.io/gh/RIP-Comm/clementine/pull/186?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None) | Coverage Δ | | |---|---|---| | [emu/src/cpu/arm7tdmi.rs](https://app.codecov.io/gh/RIP-Comm/clementine/pull/186?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-ZW11L3NyYy9jcHUvYXJtN3RkbWkucnM=) | `83.02% <100.00%> (+0.15%)` | :arrow_up: | ... and [3 files with indirect coverage changes](https://app.codecov.io/gh/RIP-Comm/clementine/pull/186/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.