search

RIP-Comm / clementine

Gameboy Advance emulator.
MIT License
49 stars 13 forks source link

Thumb: Implement `MultipleLoadStore` #189

Closed guerinoni closed 1 year ago

guerinoni commented 1 year ago

This implements only the part clementine needs to pass the step. We should improve testing and splitting better files like module arm and module thumb

codecov-commenter commented 1 year ago

Codecov Report

Patch coverage: 96.15% and project coverage change: +0.40 :tada:

Comparison is base (fbda12d) 57.13% compared to head (2ccc3a3) 57.54%.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #189 +/- ## ========================================== + Coverage 57.13% 57.54% +0.40% ========================================== Files 37 37 Lines 2753 2777 +24 ========================================== + Hits 1573 1598 +25 + Misses 1180 1179 -1 ``` | [Impacted Files](https://app.codecov.io/gh/RIP-Comm/clementine/pull/189?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None) | Coverage Δ | | |---|---|---| | [emu/src/cpu/instruction.rs](https://app.codecov.io/gh/RIP-Comm/clementine/pull/189?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-ZW11L3NyYy9jcHUvaW5zdHJ1Y3Rpb24ucnM=) | `82.26% <91.66%> (+0.87%)` | :arrow_up: | | [emu/src/cpu/arm7tdmi.rs](https://app.codecov.io/gh/RIP-Comm/clementine/pull/189?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-ZW11L3NyYy9jcHUvYXJtN3RkbWkucnM=) | `83.39% <100.00%> (+0.39%)` | :arrow_up: | | [emu/src/cpu/opcode.rs](https://app.codecov.io/gh/RIP-Comm/clementine/pull/189?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-ZW11L3NyYy9jcHUvb3Bjb2RlLnJz) | `88.73% <100.00%> (+0.16%)` | :arrow_up: |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.