RIP-Comm / clementine

Gameboy Advance emulator.
MIT License
48 stars 13 forks source link

Refactor code for CPU #192

Closed guerinoni closed 1 year ago

guerinoni commented 1 year ago

Tests changes: Under every mod we can add test for decoding or generating ASM, in this way in other tests we can simply check the execution and we can keep more tests but more clean and with a specific goal, instead every tests is too long to read.

codecov-commenter commented 1 year ago

Codecov Report

Patch coverage: 82.69% and project coverage change: +0.93 :tada:

Comparison is base (fbda12d) 57.13% compared to head (95e66f8) 58.07%.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #192 +/- ## ========================================== + Coverage 57.13% 58.07% +0.93% ========================================== Files 37 39 +2 Lines 2753 2829 +76 ========================================== + Hits 1573 1643 +70 - Misses 1180 1186 +6 ``` | [Impacted Files](https://app.codecov.io/gh/RIP-Comm/clementine/pull/192?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None) | Coverage Δ | | |---|---|---| | [emu/src/bitwise.rs](https://app.codecov.io/gh/RIP-Comm/clementine/pull/192?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-ZW11L3NyYy9iaXR3aXNlLnJz) | `100.00% <ø> (ø)` | | | [emu/src/cpu/condition.rs](https://app.codecov.io/gh/RIP-Comm/clementine/pull/192?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-ZW11L3NyYy9jcHUvY29uZGl0aW9uLnJz) | `27.77% <ø> (ø)` | | | [emu/src/cpu/psr.rs](https://app.codecov.io/gh/RIP-Comm/clementine/pull/192?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-ZW11L3NyYy9jcHUvcHNyLnJz) | `82.02% <ø> (ø)` | | | [emu/src/cpu/registers.rs](https://app.codecov.io/gh/RIP-Comm/clementine/pull/192?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-ZW11L3NyYy9jcHUvcmVnaXN0ZXJzLnJz) | `83.33% <ø> (ø)` | | | [emu/src/memory/keypad.rs](https://app.codecov.io/gh/RIP-Comm/clementine/pull/192?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-ZW11L3NyYy9tZW1vcnkva2V5cGFkLnJz) | `26.31% <ø> (ø)` | | | [emu/src/memory/lcd\_registers.rs](https://app.codecov.io/gh/RIP-Comm/clementine/pull/192?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-ZW11L3NyYy9tZW1vcnkvbGNkX3JlZ2lzdGVycy5ycw==) | `22.93% <ø> (ø)` | | | [emu/src/memory/serial\_communication.rs](https://app.codecov.io/gh/RIP-Comm/clementine/pull/192?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-ZW11L3NyYy9tZW1vcnkvc2VyaWFsX2NvbW11bmljYXRpb24ucnM=) | `18.51% <ø> (ø)` | | | [emu/src/render/gba\_lcd.rs](https://app.codecov.io/gh/RIP-Comm/clementine/pull/192?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-ZW11L3NyYy9yZW5kZXIvZ2JhX2xjZC5ycw==) | `14.28% <0.00%> (ø)` | | | [emu/src/render/ppu.rs](https://app.codecov.io/gh/RIP-Comm/clementine/pull/192?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-ZW11L3NyYy9yZW5kZXIvcHB1LnJz) | `34.72% <0.00%> (ø)` | | | [emu/src/cpu/flags.rs](https://app.codecov.io/gh/RIP-Comm/clementine/pull/192?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-ZW11L3NyYy9jcHUvZmxhZ3MucnM=) | `69.23% <52.94%> (-30.77%)` | :arrow_down: | | ... and [11 more](https://app.codecov.io/gh/RIP-Comm/clementine/pull/192?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None) | |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.