search

RIP-Comm / clementine

Gameboy Advance emulator.
MIT License
49 stars 13 forks source link

UI: Use a fixed vector to keep ASM generated #197

Closed guerinoni closed 1 year ago

guerinoni commented 1 year ago

In this way UI is very fluid, before was very laggy at some point, because of the string that need to be render for all ASM generated since time 0. Now I created a little data struct that answer to our need in order to keep only the last 1k instructions. Seems a reasonable number. For future improvement we can enable also a possibility to save as file.

Signed-off-by: Federico Guerinoni guerinoni.federico@gmail.com

codecov-commenter commented 1 year ago

Codecov Report

Patch coverage: 95.00% and project coverage change: +0.24 :tada:

Comparison is base (6a17aed) 58.36% compared to head (6966b67) 58.60%.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #197 +/- ## ========================================== + Coverage 58.36% 58.60% +0.24% ========================================== Files 39 40 +1 Lines 2858 2877 +19 ========================================== + Hits 1668 1686 +18 - Misses 1190 1191 +1 ``` | [Impacted Files](https://app.codecov.io/gh/RIP-Comm/clementine/pull/197?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None) | Coverage Δ | | |---|---|---| | [vecfixed/src/lib.rs](https://app.codecov.io/gh/RIP-Comm/clementine/pull/197?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-dmVjZml4ZWQvc3JjL2xpYi5ycw==) | `94.73% <94.73%> (ø)` | | | [emu/src/cpu/arm7tdmi.rs](https://app.codecov.io/gh/RIP-Comm/clementine/pull/197?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-ZW11L3NyYy9jcHUvYXJtN3RkbWkucnM=) | `72.92% <100.00%> (ø)` | |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

guerinoni commented 1 year ago

@AlessioC31 The new implementation benchmark

vector_fixed            time:   [8.0615 µs 8.0822 µs 8.1040 µs]
                        change: [-57.499% -57.326% -57.162%] (p = 0.00 < 0.05)
                        Performance has improved.