RIP-Comm / clementine

Gameboy Advance emulator.
MIT License
48 stars 13 forks source link

Pipelining #198

Closed AlessioC31 closed 1 year ago

AlessioC31 commented 1 year ago

Well, it's time.

Only a problem: it doesn't work anymore (it executes fine until a certain point, then something happens)

Commit message because I want to go to bed, I will split it tomorrow :D

codecov-commenter commented 1 year ago

Codecov Report

Patch coverage: 61.60% and project coverage change: -2.48 :warning:

Comparison is base (a65dfe2) 58.55% compared to head (a0718c4) 56.08%.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #198 +/- ## ========================================== - Coverage 58.55% 56.08% -2.48% ========================================== Files 40 40 Lines 2874 2826 -48 ========================================== - Hits 1683 1585 -98 - Misses 1191 1241 +50 ``` | [Impacted Files](https://app.codecov.io/gh/RIP-Comm/clementine/pull/198?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None) | Coverage Δ | | |---|---|---| | [emu/src/cpu/arm/instructions.rs](https://app.codecov.io/gh/RIP-Comm/clementine/pull/198?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-ZW11L3NyYy9jcHUvYXJtL2luc3RydWN0aW9ucy5ycw==) | `75.81% <ø> (-1.31%)` | :arrow_down: | | [emu/src/cpu/arm/mode.rs](https://app.codecov.io/gh/RIP-Comm/clementine/pull/198?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-ZW11L3NyYy9jcHUvYXJtL21vZGUucnM=) | `20.00% <ø> (-57.15%)` | :arrow_down: | | [emu/src/cpu/thumb/alu\_instructions.rs](https://app.codecov.io/gh/RIP-Comm/clementine/pull/198?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-ZW11L3NyYy9jcHUvdGh1bWIvYWx1X2luc3RydWN0aW9ucy5ycw==) | `76.66% <ø> (ø)` | | | [emu/src/cpu/thumb/instruction.rs](https://app.codecov.io/gh/RIP-Comm/clementine/pull/198?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-ZW11L3NyYy9jcHUvdGh1bWIvaW5zdHJ1Y3Rpb24ucnM=) | `88.23% <ø> (-1.07%)` | :arrow_down: | | [emu/src/cpu/thumb/mode.rs](https://app.codecov.io/gh/RIP-Comm/clementine/pull/198?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-ZW11L3NyYy9jcHUvdGh1bWIvbW9kZS5ycw==) | `13.88% <ø> (-83.34%)` | :arrow_down: | | [emu/src/cpu/arm7tdmi.rs](https://app.codecov.io/gh/RIP-Comm/clementine/pull/198?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-ZW11L3NyYy9jcHUvYXJtN3RkbWkucnM=) | `69.51% <41.17%> (-3.41%)` | :arrow_down: | | [emu/src/cpu/arm/operations.rs](https://app.codecov.io/gh/RIP-Comm/clementine/pull/198?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-ZW11L3NyYy9jcHUvYXJtL29wZXJhdGlvbnMucnM=) | `86.44% <71.87%> (+1.09%)` | :arrow_up: | | [emu/src/cpu/thumb/operations.rs](https://app.codecov.io/gh/RIP-Comm/clementine/pull/198?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-ZW11L3NyYy9jcHUvdGh1bWIvb3BlcmF0aW9ucy5ycw==) | `86.29% <86.20%> (+0.67%)` | :arrow_up: | ... and [1 file with indirect coverage changes](https://app.codecov.io/gh/RIP-Comm/clementine/pull/198/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

AlessioC31 commented 1 year ago

Fixed, it was a missed flush :D