RIP-Comm / clementine

Gameboy Advance emulator.
MIT License
49 stars 13 forks source link

`Timer registers` implementation for `Internal memory` #92

Closed FedericoBruzzone closed 1 year ago

FedericoBruzzone commented 1 year ago

GBA-Timers

FedericoBruzzone commented 1 year ago

image These parts will need to be implemented

AlessioC31 commented 1 year ago

I think we can squash the 2 commits into 1, what do you think?

FedericoBruzzone commented 1 year ago

Maybe it is not necessary, but let us talk about it :D

AlessioC31 commented 1 year ago

Maybe it is not necessary, but let us talk about it :D

The second commit doesn't really introduce anything, no?

image

These are the changes that I see in the second commit

FedericoBruzzone commented 1 year ago

Before touching my code, it would be a good idea to separate IoRegister from LCDRegisters?

AlessioC31 commented 1 year ago

Before touching my code, it would be a good idea to separate IoRegister from LCDRegisters?

You mean to have IORegister and IORegisterAccessControl in a separate file and then have specific files for LCDRegisters, TimerRegisters etc? I think it would be a good idea. But can we group them under the same directory to avoid having too many files under the same directory? I think it would help navigate the code

FedericoBruzzone commented 1 year ago

OMG, you're right, how is it possibile? I'll delete the second commit

FedericoBruzzone commented 1 year ago

I mean that it would be a good idea create a new directory called registers within: IoRegister, LCDRegister, TimerRegister and so on.

AlessioC31 commented 1 year ago

I mean that it would be a good idea create a new directory called registers within: IoRegister, LCDRegister, TimerRegister and so on.

Yes, I think it would be good. Maybe I would not call it registers since the term register can also refer to cpu registers. Something like io_registers? But then how would we call the file that contains IORegister and IORegisterAccessControl? 🤔

FedericoBruzzone commented 1 year ago

Perfect, I'll fix everything tonight. A good name for the directory could be external_register, in this way we don't need to change the name of io_registers. What do you think about it?