Closed FedericoBruzzone closed 1 year ago
These parts will need to be implemented
I think we can squash the 2 commits into 1, what do you think?
Maybe it is not necessary, but let us talk about it :D
Maybe it is not necessary, but let us talk about it :D
The second commit doesn't really introduce anything, no?
These are the changes that I see in the second commit
Before touching my code, it would be a good idea to separate IoRegister
from LCDRegisters
?
Before touching my code, it would be a good idea to separate
IoRegister
fromLCDRegisters
?
You mean to have IORegister
and IORegisterAccessControl
in a separate file and then have specific files for LCDRegisters
, TimerRegisters
etc? I think it would be a good idea. But can we group them under the same directory to avoid having too many files under the same directory? I think it would help navigate the code
OMG, you're right, how is it possibile? I'll delete the second commit
I mean that it would be a good idea create a new directory called registers
within: IoRegister
, LCDRegister
, TimerRegister
and so on.
I mean that it would be a good idea create a new directory called
registers
within:IoRegister
,LCDRegister
,TimerRegister
and so on.
Yes, I think it would be good. Maybe I would not call it registers
since the term register can also refer to cpu registers. Something like io_registers
? But then how would we call the file that contains IORegister
and IORegisterAccessControl
? 🤔
Perfect, I'll fix everything tonight.
A good name for the directory could be external_register
, in this way we don't need to change the name of io_registers
. What do you think about it?
GBA-Timers