"active" field in bankAccount

RIP-Comm / sossoldi

"Sossoldi" is a wealth management / personal finance / Net Worth tracking app, made with Flutter.

MIT License

262 stars 73 forks source link

"active" field in bankAccount #100

Closed mikev-cw closed 1 year ago

mikev-cw commented 1 year ago

added "active" field in bankAccount Table
Edited query to select all (active) bank Accounts
Edited behavior of "Delete account" button, now just sets the account as inactive
Fixed text overflow in settings page as per #96
Imports cleanup, and general improvements

Delete your databases before testing.

theperu commented 1 year ago

Good work! Seems all fine, I just noticed one thing. If I try to add a transaction and I set a date in the past (yesterday or before) then I don't see it. No errors or warnings appear on the debug console. Maybe it is something that was already there and we didn't notice, I don't remember if I tried it before

lucaantonelli commented 1 year ago

Good work! Seems all fine, I just noticed one thing. If I try to add a transaction and I set a date in the past (yesterday or before) then I don't see it. No errors or warnings appear on the debug console. Maybe it is something that was already there and we didn't notice, I don't remember if I tried it before

About the transaction not showing up, maybe it's only because on the home page we show only the last 5 transactions. If you try to delete the today's transactions, you should see the older one.

theperu commented 1 year ago

Actually I think I was confused because we are always showing up the last 5 transactions even in the "transactions" page. If I add a transaction and I already have at least 5 of them, then I can't see the fifth anywhere. This is not related to this PR though, so it's ok to me

mikev-cw commented 1 year ago

Yeah, I think we need to speak A LOT about transactions... 😄 I'm merging this for now. Thank you!