search

RIP-Comm / sossoldi

"Sossoldi" is a wealth management / personal finance / Net Worth tracking app, made with Flutter.
MIT License
262 stars 73 forks source link

Refactor widgets code #108

Open mikev-cw opened 1 year ago

mikev-cw commented 1 year ago

Some widgets are now builded from scratch every time. We need to standardize this part of the codebase

GBergatto commented 1 year ago

I'll start doing some work related to this issue while working on the ex Account modal for issue #90

giuseppe-coco commented 8 months ago

Hi, I am new to the project and would like to contribute.

@mikev-cw , do you mean that in the code there are identical widgets repeated many times that you would like to modularize into a class?

Can you give an example in the code of which widgets you would like to convert into a separate class?

GBergatto commented 8 months ago

Welcome! Yes, there are some widgets that are shared across multiple pages but are created from scratch on each of them. The goal is to define widgets that we can reuse across the page to make the code more organized and avoid having to rewrite the same things over and over. An example, is lib/custom_widgets/transactions_list.dart which I've worked on in my last PR #118.

giuseppe-coco commented 8 months ago

Hello, sorry for my late response but I'm currently working and haven't had much time to devote to the project.

I noticed some strange things that did not allow me to understand in detail the functions of the app and the related widgets that control them, so I could not make changes.

Specifically , the app cannot find the "Main Account" .

graphs home transactions
GBergatto commented 8 months ago

@giuseppe-coco I think that that happens because you don't have any transactions, yet. Try to go to "Settings" and, in the "dev only" zone, do "clear and fill demo data". This will create a bunch of random transactions in the local database

giuseppe-coco commented 7 months ago

Yes that was the problem, thank you!