search

RIP-Comm / sossoldi

"Sossoldi" is a wealth management / personal finance / Net Worth tracking app, made with Flutter.
MIT License
262 stars 73 forks source link

Starting balance field in account creation page #109

Closed Paxol closed 1 year ago

Paxol commented 1 year ago

I added a numeric field for the startingValue field in the account creation page, this will close #106. It's my first time working with flutter, so tell me anything wrong 😅

Paxol commented 1 year ago

There is a scrolling issue that I don't know how to resolve, when the keyboard is open, some part of the form is hidden by the "create account" button:

Screenshot_20230711_115241.jpg

Screenshot_20230711_115255.jpg

theperu commented 1 year ago

Hi! First of all thanks for the contribution, to me it looks the result looks fine and achieves the problem presented in the issue. I think that the scrolling issue that you reported won't effect the user too much since they can just close the keyboard when they are done. I'll wait for the review from other people just to make sure that I didn't miss something

mikev-cw commented 1 year ago

Thank you for your contribution!!! I agreed with @theperu, we'll check for that details later. I think this is ready for merge, but this is a draft PR and cannot do that. @Paxol Do you think is ready to turn it into a regular PR?

PS: Head on our Discord!