search

RIP-Comm / sossoldi

"Sossoldi" is a wealth management / personal finance / Net Worth tracking app, made with Flutter.
MIT License
262 stars 73 forks source link

Localised decimal separator #112

Open rcasula opened 1 year ago

rcasula commented 1 year ago

Use the system default decimal separator instead of the hardcoded ..

GBergatto commented 1 year ago

Currently, we are using commas and periods inconsistently across the app. The best way to solve this is, as suggested by @rcasula, to read the local of the user. However, in this early stage we could start with the English locale as default, using dot as decimal separator and comma as thousands separator.

theperu commented 1 year ago

I agree with @GBergatto since the app is in English I think we should stick with . for the decimals and , for the thousands

Votyer commented 8 months ago

I'll take care of it

Votyer commented 8 months ago

Hello everyone, short update from my task. I changed the method "numToCurrency" in functions class so now it accept the locale as parameter. Addictionally I added the flutter lib for string internationalizing(link below) to support different languages.

I hope to close this task before the end next week

Internationalizing Flutter apps https://docs.flutter.dev/ui/accessibility-and-internationalization/internationalization

theperu commented 8 months ago

Great! We'll wait for the PR then!

Votyer commented 8 months ago

PR Opened sorry for delay! https://github.com/RIP-Comm/sossoldi/pull/128