Closed mene412 closed 4 months ago
Hi @mene412! Do you think that you could also work on the parts that you pointed out are missing in order to complete this feature? In that case we might want to keep this open
Up to today, I am unable to proceed because a part of the provider is missing, specifically budgets_provider.dart
, in order to add the budgets. I tried to modify the file, but I haven't reached a solution yet.
@mikev-cw and @lucaantonelli what do you think? Do we want to merge this now or you have suggestions/time to help mene on the next steps?
I see that this was originally a draft
PR, converted to ready for review
, then approved, for reasons I personally don't see. Now has even unresolved conflicts.
So I don't think this is ready to merge: Onboarding is a critical and primary feature that needs to be as ready as possible to merge (also to not hinder development, imagine having to do an onboarding that doesn't work every time the app is launched).
So @mene412 if there's something missing, as budget provider you mentioned, tell us if you can work on it, or you need someone else to help. Whatever the case, i think we should put this into an issue.
EDIT: If we want to merge something that's intentionally not finished (like skipping the budget feature), it's ok, but I think we should let developers force start the onboarding when they need
Issue #39 TODO: