search

RIP-Comm / sossoldi

"Sossoldi" is a wealth management / personal finance / Net Worth tracking app, made with Flutter.
MIT License
252 stars 70 forks source link

Enhanced theme handling #124

Closed andreadelsarto closed 3 months ago

andreadelsarto commented 7 months ago

Added support for dark mode, auto theme based on system settings, and persistent theme state across app restarts. Also fixed alignment issue with a button.

theperu commented 7 months ago

Good work! I just have three questions before moving forward and merging this PR:

  1. We merged another PR in the meantime which means that you should do a rebase.
  2. Did you check the Transactions page? Because it looks like we have more than one issue there with the dark theme
  3. Did you make the change for the dynamic icon on Android? Do you need new graphics to do it?

Apart from this everything looks good to me and from what I saw on Discord @mikev-cw is on the same page

andreadelsarto commented 7 months ago

Good work! I just have three questions before moving forward and merging this PR:

  1. We merged another PR in the meantime which means that you should do a rebase.
  2. Did you check the Transactions page? Because it looks like we have more than one issue there with the dark theme
  3. Did you make the change for the dynamic icon on Android? Do you need new graphics to do it?

Apart from this everything looks good to me and from what I saw on Discord @mikev-cw is on the same page

Thanks!! I need to check for the Transaction page before do the fix of pubspec.lock. For the dynamic icon I remake the logo on svg :) so i'll try to make the dynamic icon.

I'll fix it soon

theperu commented 5 months ago

Hi! Just checking in, how is it going? Let me know if you have any issue or problem working on this PR :)

andreadelsarto commented 4 months ago

Sorry, I was busy with work... I'll try to work on it this night :)

Il giorno mer 31 gen 2024 alle ore 20:16 Marco Perugini < @.***> ha scritto:

Hi! Just checking in, how is it going? Let me know if you have any issue or problem working on this PR :)

— Reply to this email directly, view it on GitHub https://github.com/RIP-Comm/sossoldi/pull/124#issuecomment-1919767875, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACL5PZF26HAZ2DBIXQTPL5TYRKJ7ZAVCNFSM6AAAAABAFARGIKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMJZG43DOOBXGU . You are receiving this because you authored the thread.Message ID: @.***>

-- There are people trying to improve everything, because everything can be improved, and I want to be one of them!