Fix checks for Pull Requests

RIP-Comm / sossoldi

"Sossoldi" is a wealth management / personal finance / Net Worth tracking app, made with Flutter.

MIT License

252 stars 70 forks source link

Fix checks for Pull Requests #139

Closed theperu closed 5 months ago

theperu commented 5 months ago

For a while we had this issue that the checks fail for every new PR. From my understanding we are using the wrong Dart SDK version (3.1.0) while it should be >=3.1.5 and <4.0.0

mikev-cw commented 5 months ago

Yeah, problem is surely this. Workflow configuration file, however, is correctly running on SDK version 3.16.0 as you can see here: https://github.com/RIP-Comm/sossoldi/blob/3b83bf40918589cc11075e37dc12df9808f951b6/.github/workflows/flutter-ci.yml#L20 So it's not clear to me where the problem is.. i will try to investigate further

theperu commented 5 months ago

Maybe we could try running flutter upgrade --dart just to make sure that we have the latest compatible version of Dart?

mikev-cw commented 5 months ago

I don't think this is related to our local environments. Now seems that clearing GH Actions cache (again) does the job... let me check again on that on next days.

...but now there are a couple of problems on tests, which were hidden 'till now by this issue! 🤣

theperu commented 5 months ago

Understood 👍🏻😂