RIP-Comm / sossoldi

"Sossoldi" is a wealth management / personal finance / Net Worth tracking app, made with Flutter.
MIT License
276 stars 75 forks source link

Onboarding Page #56

Closed 0xbaggi closed 1 year ago

0xbaggi commented 1 year ago

I develop the onboarding page (#39), following the figma design:

done:

TODO:

https://user-images.githubusercontent.com/39710037/211912680-488d5880-1f44-4e19-b6e0-51dc7712b223.mp4

tested on Pixel XL API 31 Android 12

FedericoBruzzone commented 1 year ago

Can you open the issues regarding the things that are missing?

0xbaggi commented 1 year ago

Can you open the issues regarding the things that are missing?

Sure, #57 I think we should label it as a "good first issue"

FedericoBruzzone commented 1 year ago

Can I merge this staff? :D

mikev-cw commented 1 year ago

@FedericoBruzzone Remember merging is paused for some days

FedericoBruzzone commented 1 year ago

Thanks for reminding me, write me when I can merge @mikev-cw

0xbaggi commented 1 year ago

@FedericoBruzzone @mikev-cw Can we merge this now?

FedericoBruzzone commented 1 year ago

Can we merge this now?

I'm waiting for them to tell me to proceed

mikev-cw commented 1 year ago

@0xbaggi merging of #63 has raised some expected conflicts. Can you check if you can easily resolve them? Head on Discord if you need help

FedericoBruzzone commented 1 year ago

You should update your fork, after that you can use this command locally:

git switch main
git pull main
git switch -
git rebase main

and at this point resolve conflicts in your favorite text editor.

Please, don't create another commit, after the above command use git commit --amend & git push --force to update this pull request.