Closed AntonioMiclaus closed 1 year ago
Great job! I tried this on both iOS & Android and the only thing that looks a bit strange to me is the upper part of the screen for two reasons:
Can you send a picture? I can't test your code.
Here is how it looks on iOS & Android
I agree with what you said. 👍
I've updated the appbar by removing the "back" text and the grey background and added the text "Settings" in the center with also the dark blue back arrow.
Hi! Everything looks fine to me now. Just a little question, I saw that in your commits you also pushed changes to macos/Flutter/GeneratedPluginRegistrant.swift and pubspec.lock but it don't understand why. Can you help me with that?
I noticed these files changed automatically when I tested the code with VScode + android studio. The added parts may be requirements. The parts removed may not be needed anymore or maybe only for the device I tested on. The only file I changed manually is the settings_page.dart
Understood, I have the feeling that a PR like this should contain only the changes on settings_page.dart. Maybe @FedericoBruzzone or @mikev-cw can take a look since I am not that familiar with code reviews
@theperu Yeah! Agreed. @AntonioMiclaus seems that files are still in the PR. Maybe you want to open a new one?
To remove useless commit use:
git rebase -i HEAD~5
And type "drop" in place of "pick".
Thanks for all the comments and help. I'm gonna close this request and open a new one in order to avoid further confusion.
I've added the settings_page with the four main options.