Closed Filippoml closed 1 year ago
theperu
commented
1 year ago Nice work! I tried this and I noticed that on iOS the image is a lot smaller compared to Android. Although this is not a big issue you could look in to that and see if there is an easy fix (if there isn't one it's fine we will keep it as is). You can see the video down below for reference.
FedericoBruzzone
commented
1 year ago Yes, I think it's too small
Filippoml
commented
1 year ago I see... unfortunately I am on Windows so I would have to find a way to run a iOS emulator. The reason why is a bit small is because on Android I don't have a lot of space available for the icon. One thing that we could do is to use the logo without the text "sossoldi", in this way it will appear bigger than now.
theperu
commented
1 year ago From my understanding we can use different images for Android and iOS so since on the current image there is a lot of empty space we could make the logo bigger just for the iOS images and that could solve the problem
Filippoml
commented
1 year ago The problem is not with iOS, I have noticed that the splash screen icon looks smaller on displays with higher resolution. I will see if I can find a solution for that.
theperu
commented
1 year ago Got it, I would still suggest the same solution. The images that you used have a lot of empty space and that is why it is showing like this in some devices, it should be pretty easy to modify them in order to achieve that. If you have any problem doing that you can ask on Discord.
Filippoml
commented
1 year ago I have cropped the splash screen icons, can anybody test on iOS?
theperu
commented
1 year ago Hi! Tested it again on iOS and they still look the same, I think it is because by cropping the images we lost the original resolution. I am sorry if I wasn't clear with my suggestion last time but what we need I think are the images with the resolution that we had at the start but without the white space. So the images should look like the ones that you cropped but with the starting resolution. If you have any kind of trouble with this I suggest you to reach out on Discord channel for the frontend (which is "Graphical User Interface").
theperu
commented
1 year ago Although there are a couple of things that we should sort out on this PR I think we can easily fix them in the future. So I am ok with merging this one
mikev-cw
commented
1 year ago Although there are a couple of things that we should sort out on this PR I think we can easily fix them in the future. So I am ok with merging this one
Sure, I agree.
Trying to checkout to dev/#38-splash-screen-second-try branch on Filippoml/sossoldi fork, i'm seeing an old version of the app. I think it's because all last months updates are not synced there (new database architecture, graphs page and "new transaction" page are the first 3 i 've seen).
I don't think this will be a problem and I'm going to merge this into our main.
I'll rollback if anything.
Let's remember to open issues for fixing last things here.
Thank you!
The following PR implements a splash screen icon for Web, Android and iOS. Unfortunately, I couldn't find a way to do this for Windows as well.
The splash screens have been generated through the plugin flutter_native_splash, which has been added to the project in case it may be needed in the future to update the icon.
PLEASE NOTE: The splash screen may not appear when you launch the app from Android Studio. However, it should appear when you launch by clicking on the launch icon in Android.
PLEASE NOTE: There are a number of reports that non-Google launchers do not display the launch image correctly. If the launch image does not display correctly, please try the Google launcher to confirm that this package is working.
PLEASE NOTE: The splash screen does not appear when you launch the app from a notification. Apparently, this is the intended behavior on Android 11.