search

RIP-Comm / sossoldi

"Sossoldi" is a wealth management / personal finance / Net Worth tracking app, made with Flutter.
MIT License
262 stars 73 forks source link

Transform accounts modal to a page #90

Closed theperu closed 8 months ago

theperu commented 1 year ago

Currently the lower part of every account modal shows some weird things instead of the right transactions. I think we can re-use a lot of the work that as been done for the transaction page by @GBergatto (#84 ) Figma link for reference

EDIT: After discussing this issue on discord we decided to remove the modal and use a page instead

GBergatto commented 1 year ago

I'm a bit busy in this period but I'll take a look

GBergatto commented 1 year ago

I've quickly tried to copy and paste some code from lib/pages/transactions_page/widgets/list_tab.dart and it works.

GBergatto commented 1 year ago

I've also noticed that we have a few blocks of code that do almost the same thing scattered across the codebase. For example, I've created a widget to display a transaction inside lib/pages/transactions_page/widgets/transaction_list_tile.dart and something very similar has been done inside lib/custom_widgets/transactions_list.dart.

I believe we should define some rules on how to make widgets more reusable to avoid rewriting the same code over and over and to keep some consistency across different pages.

Each page should be wrapped inside its own folder and broken down into multiple widgets. If those widgets are specific to that page they should stay inside a widgets subfolder. If they are shared across different pages (like the one for transactions) they should stay inside a shared folder like lib/custom_widgets

theperu commented 1 year ago

Yes, I 100% agree with you. Unfortunately sometimes we haven't followed this practice but we will try to focus more on this and also in the near future we will take a look at the code and try to fix this kind of things once and for all.

GBergatto commented 1 year ago

@theperu can you please edit the description of this issue to say that, as discussed on Discord, we will transform this modal into a regular page? I'm starting to work on it now.