search

RIPAGlobal / scimitar

A SCIM v2 API endpoint implementation
MIT License
61 stars 43 forks source link

Some error responses do not meet SCIM specification out of the box #124

Closed spryffee closed 5 months ago

spryffee commented 5 months ago

Hi! Thank you for this gem.

According to README, scimitar under the hood generates appropriate SCIM error response when it occurs. It is true for 404 on resources but if you add uniqueness validation it renders {:error=>"Conflict", :status=>"409"} instead of SCIM compliant JSON. Should I overwrite save! method to render proper error response or what is expected? Same applies to 401, it renders {:error=>"Unauthorized", :status=>"401"} when token_authenticator returns false.

I'm using scimitar v2.7 and samples from the repo

spryffee commented 5 months ago

Sorry, the issue is invalid. This was due to some changes on my side

pond commented 5 months ago

@spryffee For once, my workload and procrastination that delay me getting back to dealing with Scimitar issues pays dividends! :joy:

Glad you figured it out.