Feature request: async http/ws

RIPE-NCC / ripe-atlas-cousteau

Python client for RIPE ATLAS API

GNU General Public License v3.0

65 stars 26 forks source link

Feature request: async http/ws #57

Open yan-foto opened 3 years ago

yan-foto commented 3 years ago

Before submitting a PR, I wanted to ask if the maintainers or community are interested in async version of HTTP requests and WebSocket operations (for streams). I have a proof of concept under my fork.

chrisamin commented 2 years ago

Hi,

I would potentially be interested in such a pull request. If you're still willing then please look to base it on the release-1.5.0 branch as I have already converted the upcoming release to use python-socketio.

Note that the async version should be backwards-compatible with the existing sync version.

yan-foto commented 2 years ago

That sounds good! Have you taken a look at how I do it at the moment? I have two different classes for the legacy and the async stream. Is that ok?