search

RIPE-NCC / ripe-atlas-probe-measurements

RIPE Atlas probe measurement source code
Other
41 stars 18 forks source link

Remove 0/8 and 240/4 special cases in bad_ipv4 #7

Closed schoen closed 1 year ago

schoen commented 2 years ago

This pull request removes the special case for 0/8 and 240/4 in bad_ipv4 to make it possible for people to submit experiments involving addresses within these (currently reserved) IPv4 address ranges, once the Atlas backend server permits it as a matter of policy, and assuming that the probe host is capable of generating and receiving the necessary packets for the experiment (which is now default behavior in the Linux kernel, since kernel release 5.2).

0.0.0.0/32 and 255.255.255.255/32 are still treated as invalid because they have special meanings apart from the IP address ranges to which they belong.

(@PhilipHomburg indicated that he did not want to make the change that we originally suggested that would also remove part of 127/8 and 224/4, so this patch does not remove those ranges.)

schoen commented 1 year ago

I see that @PhilipHomburg took care of this earlier last year with a different patch, so I'm going to close this PR. (Thank you!)