RIPE-NCC / ripe-atlas-sagan

A parsing library for RIPE Atlas measurement results
GNU General Public License v3.0
48 stars 25 forks source link

pep8 + python3 support #67

Closed danielquinn closed 8 years ago

danielquinn commented 8 years ago

As per Jan's recommendations regarding getting this package into Fedora, I've added Python3 support to the parse_abuf script.

I think it'd be a good idea for @phicoh to take a look at this though before we consider this ready to merge, since he wrote it and has the most experience with it.

phicoh commented 8 years ago

I didn't write this. Probably Bert did. The changes look fine, but I didn't try to run it.

danielquinn commented 8 years ago

Well then, I recommend that we remove it completely.

I tried to run it just now and I have no idea how to do it. There's no help information and no comments in the file explaining what it does or how to use it.

Any objections?

danielquinn commented 8 years ago

Decision made: the script is going away.