search

RIPE-NCC / ripe-atlas-sagan

A parsing library for RIPE Atlas measurement results
GNU General Public License v3.0
48 stars 25 forks source link

Add support for non-DNS names in subjectAltName extensions #83

Closed chrisamin closed 7 years ago

chrisamin commented 7 years ago

The Subject Alternative Name is often not a DNS name, particularly for intermediate certs in the chain. This change will case such names to be represented in the openssl-style "/CN=BLABLA-BLA" format instead of as a non-serializable cryptography Name object.

danielquinn commented 7 years ago

I'm a little concerned about the number of indents you've got by the time you get to line 116, so maybe that (c|s)ould be broken up into a separate method, but honestly, that's a nitpick at this stage. Looks good to me :-) Thanks for asking!