search

RIPE-NCC / ripe-atlas-sagan

A parsing library for RIPE Atlas measurement results
GNU General Public License v3.0
48 stars 25 forks source link

Drop Python 3.3 & add 3.6 #86

Closed danielquinn closed 5 years ago

danielquinn commented 6 years ago

Were it up to me, I'd drop 2.7 as well, but I figure that's a hard-sell at this point ;-)

Apparently, there's some known issues with how Travis handles multiple Python environments. So after some poking I realised that the testing strategy we were using was redundant anyway: We were using tox to build python environments in each Travis container -- containers that were already being spun up for specific Python versions.

This commit drops the use of tox in Travis (though it keeps the tox.ini file for local development & testing) and instead instructs Travis to run the tests natively after installing Sagan in the container.

robert-kisteleki commented 6 years ago

I'd agree that removing python 2.7 would be a bit premature.

danielquinn commented 6 years ago

2 years left!

astrikos commented 6 years ago

Yeah tox doesn't really make much sense nowadays that everything is a container :). But it's good if you want to run tests on your local env before sending it to travis. Same logic goes also with cousteau and magellan so probalby it makes sense to have all the 3 in sync in terms of how it's tested. (drop tox from everywhere or make it work everywhere)