RIPE-NCC / ripe-atlas-software-probe

GNU General Public License v3.0
252 stars 61 forks source link

Git clone fails in submodule #103

Closed nomadeon closed 3 months ago

nomadeon commented 3 months ago

On Debian, the following fails: git clone --recursive https://github.com/RIPE-NCC/ripe-atlas-software-probe.git

With error: fatal: remote error: upload-pack: not our ref d72872cc6bb9ed5da47dcf1dc726fd8a36c6058f fatal: Fetched in submodule path 'probe-busybox', but it did not contain d72872cc6bb9ed5da47dcf1dc726fd8a36c6058f. Direct fetching of that commit failed.

Have tried the following alternatives that result in the same error Alt 1: git clone https://github.com/RIPE-NCC/ripe-atlas-software-probe.git # not recursive cd ripe-atlas-software-probe git submodule update --init --recursive Alt 2: git submodule init git submodule update --no-fetch

The AI overlords inform me this error could indicate:

  1. The submodule repository might have been force-pushed, and the commit no longer exists.
  2. The submodule might be pointing to a commit that hasn't been pushed to the remote repository.
Oorweeg commented 3 months ago

+1 On this issue, ended up doing a checkout of an earlier commit pre 56fbfbf50fed7bb06268c5721076e6a62e552039 and manually cloning the submodule to be able to get it to build.

mtheofy commented 3 months ago

+1 on this.

@Oorweeg can you please share some more details of your solution?

Oorweeg commented 3 months ago

Looks like the issue with the submodule repo has been fixed so haven’t tried 5090 again yet, but I built for Debian against the older commit for 5080 using the following method

git clone --recursive https://github.com/RIPE-NCC/ripe-atlas-software-probe.git

cd ripe-atlas-software-probe

rm -rf probe-busybox

git clone https://github.com/RIPE-NCC/ripe-atlas-probe-measurements.git probe-busybox

git checkout 67b0736887d33d1c42557e7c7694cbd4e5d8e6ee

git submodule update

build-config/debian/bin/make-config
Oorweeg commented 3 months ago

Confirmed 5090 builds OK for me now anyway now the submodule repo is fixed 👍

mtheofy commented 3 months ago

Also confirm that 5090 builds are now OK using the generic instractions of INSTALL.srt.

cd ripe-atlas-software-probe
git submodule update
dpkg-buildpackage -b -us -uc
cp ../ripe-atlas-*.deb .
cd ..
dpkg -i ripe-atlas-common_????_amd64.deb ripe-atlas-probe_????_all.deb

FWIW, successfully migrated a probe from a bullseye VM to a bookworm with bookworm-backports enabled. Keys are now located under /etc/ripe-atlas.

systemctl enable ripe-atlas.service
cp /path-to-keys/probe_key /etc/ripe-atlas
cp /path-to-keys/probe_key.pub /etc/ripe-atlas
chown ripe-atlas:ripe-atlas /etc/ripe-atlas/probe_key*
chmod 600 /etc/ripe-atlas/probe_key
systemctl start ripe-atlas.service
nomadeon commented 3 months ago

Confirmed working here as well, will close. Thanks all!