Proper XDG Base Directory Specification support

RIPE-NCC / ripe-atlas-tools

Official command-line client for RIPE Atlas

GNU General Public License v3.0

183 stars 48 forks source link

Proper XDG Base Directory Specification support #220

Closed kgaughan closed 4 years ago

kgaughan commented 4 years ago

ripe-atlas currently half-implements the XDG Base Directory Specification. This commit fixes the support to look for XDG_CONFIG_HOME first, as it ought to.

(This PR fixes #204, which had a typo, and thus was broken.)

Unfortunately, this PR also contains a bunch of changes to make the build system happy as the test suite has been broken for quite a while.

I should note that I also had to peg the version of mock at 3.0.5 as this is the last version that supports Python 2.7.

chrisamin commented 4 years ago

Thanks for this, it looks good. I'm going to rip out Python 2.7 support soon, so you've made my job a bit easier there by fixing and simplifying the build system.