search

RIPE-NCC / ripe-atlas-tools

Official command-line client for RIPE Atlas
GNU General Public License v3.0
183 stars 48 forks source link

After streaming, ripe-atlas hangs… #237

Closed Ernst2020 closed 1 year ago

Ernst2020 commented 1 year ago

Running ripe-atlas-tools on python 3.10 on alpine in a Docker container. Works fine, except that after creating a measurement and streaming the results, after the “Disconnected from stream” the process hangs. Only ctrl-c can stop it. It appears to be some thread that still hangs in lock.acquire() in threading.py.

Similar to a case like this: https://forums.raspberrypi.com/viewtopic.php?t=328771 where it is noted that a thread has not been joined. Alas, I am not familiar with python. Is this some bug of ripe-atlas-tools?

Changing the lock.acquire() to a SystemExit works. But that is a very bad kludge. No other python code in that container so there is no risk doing this kludge but really would like to know whether this is a bug or not.

Also, looking at the code I don’t think that ripe-atlas-tools does use any threading? A grep for the “thread” or”threading” words gets no hits. What is happening?

Ernst2020 commented 1 year ago

Update: version 3.0.3 (commit c999953) solves this.