Closed bernhardmgruber closed 5 years ago
You may want to verify this internally. I tested it on the public TiGL and it required some modifications, especially regarding enums, as they are now properly scoped and no prefixing is performed anymore.
Hi Bernhard, thanks for your contribution, and sorry for the late response. The changes look good, I still got two questions:
std::numeric_limits<int>::max()
? Would be better understandable in my opinion, or alternativlely define a constant maxOccurs_unbounded
?ChildWithArgsReader2
got removed. Is there another function for this now (e.g. used in CCPACSWingProfiles::ImportCPACS
)?Thank you for the input!
Looks good to me now.
Perfect, works well, thanks a lot!
removed custom unique_ptr
merged overloads of TixiReadElements
removed clashed enum prefixing, as enums can no longer clash
removed option to generate scoped enums, they are generated by default now
using std::unique_ptr instead of tigl::unique_ptr
enabled deleted special member generation by default
simplified a bit of generated code
using using instead of typedef when generating exports into tigl namespace
replaced std::cerr by LOG(ERROR) for non generator builds for cardinality error messages
minOccurs and maxOccurs are now always interpreted
updated test reference data