search

RISCfuture / dropbox

An easy-to-use client library for the official Dropbox API.
MIT License
518 stars 46 forks source link

Thumbnails support #1

Closed berkes closed 14 years ago

berkes commented 14 years ago

Hello. I have been playing with thumbnail support in Dropbox. It is not (or does not appear to be) in rdropbox. https://www.dropbox.com/developers/docs#thumbnails

The difficulty is the note: "The thumbnails API call is served by the api-content subdomain unlike most calls which are served by the api subdomain. "

So, first the question: would you be interested in a pull request that adds thumbnail support at all? And if so, how would you prefer the details to be handled?

I am not very experienced ruby developer, so please don't expect a merge-and-go solution from me :)

Bèr

berkes commented 14 years ago

While diving deeper into your code, I see you have the content-api part sorted out already in ALTERNATE_HOSTS. Sorry for that, ignore my second bullet on that.

berkes commented 14 years ago

please see http://github.com/berkes/dropbox/commit/acd09a64d93484fcfd8c2b88131df9dd4c8cbeb4 for my go on this.

RISCfuture commented 14 years ago

I'll merge it in but it needs specs first. Give me a little bit to write these up.

RISCfuture commented 14 years ago

Argh, pushed out the commit (+ specs and doc changes) and forgot to set the --author attribute. Sorry =/

berkes commented 14 years ago

NP. I am happy enough about having this in. Thanks for all the additional documentation and specwriting. I really need to get into that too. But one thing a time (first finish the pickaxe book :P)