RISPaDD / biospecdb

Biosample Spectral Repository
BSD 3-Clause "New" or "Revised" License
0 stars 1 forks source link

S3 storage: don't clobber and make more secure #351

Closed jamienoss closed 6 months ago

jamienoss commented 6 months ago

Production deployment uses AWS S3 and django-storages to generate temporary access URLs to downloadable data.

Changes:

In relation to #349, the generated URLs are that for S3, e.g., https://biospecdb-media-files.s3.amazonaws.com/, and not /media/ as specified in biospecdb.urls which means login is NOT required to access the downloads - they are available post-logout, but are temporary. Login is required to obtain the generated URL in the first place though.

Punt:

codecov[bot] commented 6 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 90.79%. Comparing base (106d2f5) to head (d82c478).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #351 +/- ## ======================================= Coverage 90.79% 90.79% ======================================= Files 28 28 Lines 2237 2237 ======================================= Hits 2031 2031 Misses 206 206 ``` | [Flag](https://app.codecov.io/gh/RISPaDD/biospecdb/pull/351/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=RISPaDD) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/RISPaDD/biospecdb/pull/351/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=RISPaDD) | `90.79% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=RISPaDD#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.