search

RITlug / ritlug.github.io

RITlug website
https://ritlug.com
Creative Commons Zero v1.0 Universal
13 stars 22 forks source link

Add pagination to announcements and talks #43

Open thenaterhood opened 8 years ago

thenaterhood commented 8 years ago

Right now, the talks and announcements pages have no pagination and will just continue to get longer. As far as I'm aware, Jekyll doesn't support pagination of multiple things natively so some JavaScript magic or other "creative" method of doing it may need to be implemented. Github pages doesn't allow Jekyll plugins.

axk4545 commented 6 years ago

@thenaterhood I think you can use paginate...

thenaterhood commented 6 years ago

In this case maybe not, because paginate assumes you have a single stream of posts. The RITlug site has two streams, one for talks and one for announcements.

ct-martin commented 6 years ago

I don't have time to look at it for now, but here's the docs page showing that GitHub does support the paginate plugin:

https://help.github.com/articles/configuring-jekyll-plugins/#default-plugins

ct-martin commented 6 years ago

To add some more to this, RITlug's site is organized as a bunch of categories with indexes for each category ("sections" per say). Pageinate (at least the version on GitHub) only pages all categories together, and can't page individual categories. In #151 I'm cheating by limiting to about 2 semesters of posts (and an "archive" page), but this isn't a perfect approach. Unless we want to completely restructure the RITlug site (which I'm not going to do), then this will have to go on the back burner until GitHub decides to change to the new plugin.

For ref: https://jekyllrb.com/docs/pagination/

jwflory commented 6 years ago

I think #151 is probably the best we can do to address this for now. After PR #151 is merged, I suggest we also close this issue as complete / resolved, since there is not a better workaround until GitHub enables support with the pagination plugin. If support is ever added, we can revisit then.

ct-martin commented 6 years ago

@jwflory how about a "blocked" label? At some point I do want to do it and I might be able to minimally implement some of it in the future

jwflory commented 6 years ago

@ct-martin That works – could you elaborate on what exactly is the blocker and what needs to happen to unblock this ticket? This will help if we revisit this six months, a year, or two eboards from now into the future.

ct-martin commented 6 years ago

@jwflory Sure. The blocker is that there is not an easy way to do this. There are two ways that this will be accomplished:

  1. GitHub updates to the new plugin for pagination
  2. Whoever ends up implementing it fudges the functionality with some Jekyll tricks or pseudo-manually (neither of which are great, but they could be done)
ct-martin commented 6 years ago

Removing announcements from this as the announcements feed is being deprecated. Talks should still be looked at for this.

Tjzabel commented 6 years ago

@ct-martin is this issue still relevant?

ct-martin commented 6 years ago

@Tjzabel I'm not sure. It'd be nice if it was, but I may close it soon. Ping me again in a couple weeks to check if there are any GH Pages updates