Closed icflournoy closed 6 years ago
I agree with Justin's suggested changes. I am going to approve this review on the basis that Justin's changes go through. Thanks!
@icflournoy Reminder ping to check out this PR if you have time this week. :slightly_smiling_face:
@icflournoy Ping, think we could close this one out this week?
@jwflory @Tjzabel Requested changes have been made, as always I appreciate the feedback. Was focused elsewhere last week, so apologies for letting this go stale.
Should I squash my commits before we merge?
Should I squash my commits before we merge?
@icflournoy Yes, if you can rebase and squash commits, that would be great. I think you know how to rebase but if for some reason you have a problem, feel free to ask for help.
This PR adds basic documentation of the secretary role.