search

RITlug / teleirc

Go implementation of a Telegram <=> IRC bridge for use with any IRC channel and Telegram group
https://docs.teleirc.com/
GNU General Public License v3.0
141 stars 45 forks source link

add "!" for people without a username #372

Closed randomhydrosol closed 2 years ago

randomhydrosol commented 3 years ago

this is an approach we are using because anyone can put as somebody else's and effectively impersonate them

Tjzabel commented 3 years ago

Thanks for this PR @anupritaisno1!. At this moment I am unsure if this issue is something that would be beneficial to the main TeleIRC branch.

Tjzabel commented 3 years ago

I love the basic idea of this issue. However, I am not sure an IRC user is going to fundamentally understand that a Telegram user with a name of !User is one without a username set. Due to this, I believe this PR may bring more confusion than it fixes.

jwflory commented 3 years ago

Hi @randomhydrosol, I tried to rebase this Pull Request on latest changes in main, but I do not think you allowed maintainers to make edits to your Pull Request. Could you please rebase this PR on latest changes in main since our CI pipeline is working again?

If all the tests pass, we can reopen this for discussion in the Telegram group on a path forward here. Otherwise we can close this out as stale.

Tjzabel commented 2 years ago

Hello,

I think this change will cause more confusion than it solves in the long-run. We cannot expect IRC users to immediately understand what a ! means in front of a Telegram name, and therefore I do not think this change should be merged into the main codebase.

I think this is a great idea overall, and you are welcome to make use of it in your own TeleIRC fork 🙂