RIVeR-Lab / numl_val_workspace

repository for vcstool workspaces
0 stars 0 forks source link

Custom messages #5

Closed allspawj closed 8 years ago

allspawj commented 8 years ago

@velinddimitrov rosForearmPlugin currently has custom messages inside of it. Presumably other projects will get more custom messages as time goes on. I am recommending that we move those messages to a package dedicated to custom messages. Candidates are numl_val_misc_custom_msgs, numl_val_misc_numl_msgs, or numl_val_msgs as a new repo. Thoughts?

(my vote is numl_val_msgs)

kevin63857 commented 8 years ago

my vote is also for numl_val_msgs

velinddimitrov commented 8 years ago

@allspawj yes, i agree, numl_val_msgs sounds good to me, we can always refactor to more specific repo names such and numl_val_misc_msgs if needed, but I doubt we will have that many custom messages. Do you want me to make the repo or do you want to do it?

velinddimitrov commented 8 years ago

@murphywonsick sorry, going to have the change the diagram again ^ :)

allspawj commented 8 years ago

numl_val_msgs it is

allspawj commented 8 years ago

@kevin63857 repository created, for now put your armplugin messages into here and update references in your code.

kevin63857 commented 8 years ago

This new repo isn't in the standard set of repos pulled when downloading with vcstool from the yaml file in numl_val_workspace

allspawj commented 8 years ago

Fixed, if you pull on workspace it should now be added.

velinddimitrov commented 8 years ago

I am closing this for now.