search

RJ-Infinity / ThisCord

A Discord "Mod" / injector
3 stars 0 forks source link

Clean up discord ghost processes when closing #18

Closed titushm closed 1 year ago

titushm commented 1 year ago

Discord sometimes leaves ghost processes open even when quit, we need to close these to avoid messing up stuff

RJ-Infinity commented 1 year ago

the first question here is "is this beacuse of ThisCord or is it a bug with discord?" beacuse if it is thiscord it should be fixed but if its discord we have two options.

  1. create a workaround for the issue. i.e. notice when this bug is happening and kill all discord processes. there are however issues with this. i.e. it will slow down the standard opening of thiscord
  2. or we could fix the issue. this however will mean that if you close a non injected instance then you will have the issue on the next startup (also does this issue effect standard discord starting or is it just when its done with ThisCord?)
RJ-Infinity commented 1 year ago

also is this connected in any way to #2?

titushm commented 1 year ago

They are seperate, this is for cleaning processes.

2 is for getting a more stable injection

titushm commented 1 year ago

the first question here is "is this beacuse of ThisCord or is it a bug with discord?" beacuse if it is thiscord it should be fixed but if its discord we have two options.

  1. create a workaround for the issue. i.e. notice when this bug is happening and kill all discord processes. there are however issues with this. i.e. it will slow down the standard opening of thiscord
  2. or we could fix the issue. this however will mean that if you close a non injected instance then you will have the issue on the next startup (also does this issue effect standard discord starting or is it just when its done with ThisCord?)

Bug with discord needs to be fixed either way

titushm commented 1 year ago

I'm thinking maybe the backend