Closed tmak closed 7 years ago
Looks good, thanks for the PR - hadn't really considered the effect you mentioned, so very happy to accept this PR.
I have a release planned for pypi this weekend, so this will be in version 4.0.1.
Thanks again!
@RJT1990 Thanks for the quick merge!
Any update on releasing 4.0.1
? We're keen to test it in our environment.
I've got quite a lot of big changes in the next release, but expect to get it out in the next few days once I've written the documentation.
Should work in latest version. Apologies for delay on getting this in - let me know if it isn't working for you
@RJT1990 Great work on the new release!
I noticed you reintroduced matplotlib in the global scope by importing it at the top of the neural network models and also by including it in the requirements file. We will still have issues with our server environments. Is there any way we can avoid this?
Ah sorry - I'm an idiot for doing that. Will put out a fix tonight
@RJT1990 Let me know if you'd like me to submit a PR for this fix.
Hey - sure, that might be helpful actually if you have time to spare. I'm a bit tied down this month so can't guarantee movement from my side.
Hey - I pushed a new version that should fix this issue. It works for my Jenkins build now.
Right now it's not possible to use pyflux in a python environment which is not configured for Tk, which is the case for most server environments:
This PR moves all
matplotlib
imports from the global scope into the different plotting functions so that Tkinter is only required if you actually use the plotting capabilities of pyflux.