Open jeabraham opened 5 years ago
documentation says
brew install google-sparsehash zlib cmake
PKG_CONFIG_PATH=/usr/local/opt/zlib/lib/pkgconfig
(Setting PKG_CONFIG_PATH is only required with HomeBrew.)
is this incorrect?
or is brew install pkgconfig
more accurate? if so where in the instructions?
would be cool to get a PR on this @jeabraham
It wasn't when I wrote it. And AFAIK there's no need to install pkgconfig manually, but I can only confirm that from the travis file where this is the case.
I will have to update the install instructions concerning lzvn, but there will be enough time for that :)
The user does need to have pkgconfig installed. Brew might not be the best way to install it, but it’s what I did to fix the problem. I think people who do regular development in C already have it installed, so won’t notice the problem. (I’m more of a Java and Python developer myself, and my computer is new, so I didn’t have it installed.). Also, after installing it I had to rm -R the “build” directory and start over. Running the make commands again wasn’t enough.
brew install pkgconfig should go in the instructions.