search

RJVB / macstrop

RJVB's repository of alternative macports, with ports missing from or overriding those in the standard collection, including a set of KF5 ports.
20 stars 9 forks source link

poppler-qt5: wrong Qt5Core version #100

Closed 21stcaveman closed 5 months ago

21stcaveman commented 8 months ago

number 100.. here we go: trying to upgrade poppler-qt5, seems like it is looking for QT5 5.12 and fails:

CMake Error at CMakeLists.txt:162 (MESSAGE): Could not find the 5.12 version of Qt5Core. If you're not interested in the features it provides set the cmake ENABLE_QT5 option to OFF Call Stack (most recent call first): CMakeLists.txt:212 (find_soft_mandatory_package)

I assume it is because I'm using qt5-kde which provides 5.9.8

21stcaveman commented 8 months ago

confirmed, changing 5.12 to 5.9 in poppler-24.01.0/CMakeLists.txt works, the port can be build and installed manually with that.

RJVB commented 8 months ago

confirmed, changing 5.12 to 5.9 in poppler-24.01.0/CMakeLists.txt works, the port can be build and installed manually with that.

24.01.0? Wow, my version of the port is still at 0.89.0 so there must have been a version naming change...

And yes, unfortunately there will be an increasing number of ports that don't work with Qt 5.9.8 from port:qt5-kde . There isn't much I can do about that.

Do you actually use KF5 applications?

21stcaveman commented 8 months ago

I do, been using Kate, Dolphin and Konsole for some years now on my mac thanks to you. Specially Dolphin.

21stcaveman commented 7 months ago

Just got back to this. Still the same issue with the latest commit

RJVB commented 7 months ago

Damn. I don't see how that can be, but at the moment I'm in big shit myself. My X11 environment refuses to start, and it's there that I did all my work >:(

21stcaveman commented 7 months ago

oh no.. this can wait, wish you luck fixing that!

RJVB commented 7 months ago

Thanks!

21stcaveman commented 5 months ago

was upgrading the system again, and ran into issues with poppler again. Looked at the patch you merged on Jan 31st, and that doesn't seem to be working as intended as I had to resolve two issues in order to build poppler: change QT version from 5.12 to 5.9 in CMakeLists.txt, AND change C++ standard from 20 to 17 in the same file. Judging by the fact that I still had C++ standard set to 20 after the patch stage, it seems like that commit is not doing what it was supposed to. Just fyi

RJVB commented 5 months ago

On Monday May 06 2024 10:03:21 Hamid wrote:

doesn't seem to be working as intended as I had to resolve two issues in order to build poppler: change QT version from 5.12 to 5.9 in CMakeLists.txt,

Does the patchfile patch-allow-older-deps.diff not get applied on your end? It does for me... and it sets the minimum Qt5 version to 5.8 .

AND change C++ standard from 20 to 17 in the same file. Judging by the fact that I still had C++ standard set to 20 after the patch stage, it seems like that commit is not doing what it was supposed to. Just fyi

That's even weirder, because poppler 24.01.0 has CXX_STANDARD 17 in its CMake file. Are you certain you're installing my port? ;)

21stcaveman commented 5 months ago

nevermind... I'm dumb! somehow, I have switched to 24.04.0 ..

RJVB commented 5 months ago

nevermind... I'm dumb! somehow, I have switched to 24.04.0 ..

Welcome to the club ;)

Does the patchfile still apply (and the premise old that Qt5.8 is supported)?

21stcaveman commented 5 months ago

yup, 24.04.0 builds with those modifications.

RJVB commented 5 months ago

Thanks. I might decide to update my port then...