search

RJVB / macstrop

RJVB's repository of alternative macports, with ports missing from or overriding those in the standard collection, including a set of KF5 ports.
20 stars 9 forks source link

libaacs should pull in Bison #41

Closed Tatsh closed 5 years ago

Tatsh commented 5 years ago

libaacs has a syntax error when used with the macOS' /usr/bin/yacc. Installing bison @3.3.2 fixes this issue.

RJVB commented 5 years ago

On Monday March 18 2019 20:37:16 Tatsh wrote:

libaacs has a syntax error when used with the macOS' /usr/bin/yacc. Installing bison @3.3.2 fixes this issue.

The port already has a build dependency on bison:

depends_build       port:perl5 \
                    bin:flex:flex \
                    bin:bison:bison \
                    port:gettext

Do you by any chance also have /usr/bin/bison?

Tatsh commented 5 years ago

Yes it comes with macOS (or maybe it gets placed here by Xcode). It's protected by SIP.

 $ /bin/ls -laO /usr/bin/bison
-rwxr-xr-x  1 root  wheel  restricted,compressed 18288 Feb  5 00:28 /usr/bin/bison
RJVB commented 5 years ago

SIP doesn't really matter here, the question is more what version you have.

Can you confirm that this is actually the command that was used and failed?

For the record: I use a bin:bison type of depspec exactly because it allows to use any available bison. I did that to avoid having to install port:bison on my Linux rig; the system bison is v3.0.2 there.

Tatsh commented 5 years ago

The command is bison -y without a path, which resolves to Apple's /usr/bin/bison by default. On Mac, maybe it should be port:bison depspec?

Tatsh commented 5 years ago

Unless you want to patch it:

... libaacs/work/libaacs-0.9.0/src/file/keydbcfg-parser.y:1.1-5: invalid directive: `%code'
... libaacs/work/libaacs-0.9.0/src/file/keydbcfg-parser.y:1.7-14: syntax error, unexpected identifier
RJVB commented 5 years ago

I've already pushed a change to the depspec; doesn't that fix the issue?

Tatsh commented 5 years ago

Yes it is fixed.