search

RJVB / macstrop

RJVB's repository of alternative macports, with ports missing from or overriding those in the standard collection, including a set of KF5 ports.
20 stars 9 forks source link

Fix zstd port (quoting issue) #51

Closed Tatsh closed 4 years ago

Tatsh commented 5 years ago

I'm on macOS 10.15 Catalina but I am still using Xcode 10.1. I know from experience quoting in Tcl is not quiet like Bash (expansion quoting is not necessary) so this fixes them and allows zstd to build.

Without this fix, the last quote in CXXFLAGS is not detected so the command is incomplete as it looks for the last ", which still seems incorrect as the command would be "/some/clang" "-Os somefile (even if the final quote were present it would still be incorrect for shell anyway).

Probably should do a squash merge for this as I do not know why the other commits are here.

Tatsh commented 4 years ago

Please see here: https://github.com/Tatsh/port-overrides/blob/master/macstrop/archivers/zstd/Portfile . Closing this PR.