search

RJVB / macstrop

RJVB's repository of alternative macports, with ports missing from or overriding those in the standard collection, including a set of KF5 ports.
20 stars 9 forks source link

port:meson : mesonlib.darwin_get_object_archs only accepts str type #64

Closed Tatsh closed 4 years ago

Tatsh commented 4 years ago

Related to #52. mesonlib.darwin_get_object_archs only accepts str and does not convert Path objects automatically.

RJVB commented 4 years ago

Why is this not an issue with the mainstream port? If it is, per my previous request for port:VLC, please file a trac ticket and put me on the CC list (you can use the "maintainers" field for that.

If it's an upstream (Meson) issue, please consider filing a ticket upstream too. That's MacPorts policy.

Tatsh commented 4 years ago

From what I can tell, this is fixed in newer versions of Meson but not in a release.

RJVB commented 4 years ago

So again this is something that does affect the main port as well...

Tatsh commented 4 years ago

My patch was accepted upstream. Could you include this patch until they make a new release?

https://github.com/mesonbuild/meson/pull/7022

RJVB commented 4 years ago

Sure, as soon as I get around to it!

RJVB commented 4 years ago

Patch incorporated (still applies) even though there has been a new version 2 days ago?!

Tatsh commented 4 years ago

No. The new version has my change.

RJVB commented 4 years ago

0.54.2 ? Then how come the patch (created from your commit) still applies? It's not one of those that applies infinitely...

Tatsh commented 4 years ago

I stand corrected. The 0.54.2 release is based on a commit from 225 commits ago. It does not contain my change. They seem to do releases like so:

  1. Make major version branch - 0.54, tag 0.54.0. This is where all patches to 0.54 will go, but changes like mine would never go here. That would be version 0.55 I guess.
  2. Merge patches, tag each point release from this branch - 0.54.2
RJVB commented 4 years ago

OK, so they use release branches which presumably get bug fixes but not (all) new features.

Your patch seems to be a bugfix...