RJVB / macstrop

RJVB's repository of alternative macports, with ports missing from or overriding those in the standard collection, including a set of KF5 ports.
20 stars 9 forks source link

macOS - Quassel Client missing icon, localised name #78

Closed Tatsh closed 4 years ago

Tatsh commented 4 years ago

In the past the icon was present in the app bundle. This wouldn't be a big deal but it shows a generic app icon in the dock when the app is not running.

MacOS-2019-12-08 11-32-58

Also there should be a localised name or the app bundle name should simply be Quassel Client.app.

RJVB commented 4 years ago

This has been coming for a while: I don't have time enough to maintain ports I don't use myself esp. if there's an equivalent among my ports (kf5-konversation). Retiring my copy, sorry.

RJVB commented 4 years ago

PS: my own build from March this year also doesn't have an embedded icon, from how far back into the past does your memory come?!

Tatsh commented 4 years ago

Oddly enough, I rebuilt after copying your Portfile to my port set and it now has an icon and the proper name.

Resources-2019-12-08 23-19-32
RJVB commented 4 years ago

Did you install with the +kde variant? That variant sets WITH_BUNDLED_ICONS=OFF, which a priori means that no icons will be embedded into the Qt resource, but which in hindsight could also mean no bundle icon will be installed.