search

RKrahl / archive-tools

Tools for managing archives
Apache License 2.0
1 stars 2 forks source link

CVE-2007-4559 Patch #73

Closed TrellixVulnTeam closed 1 year ago

TrellixVulnTeam commented 1 year ago

Patching CVE-2007-4559

Hi, we are security researchers from the Advanced Research Center at Trellix. We have began a campaign to patch a widespread bug named CVE-2007-4559. CVE-2007-4559 is a 15 year old bug in the Python tarfile package. By using extract() or extractall() on a tarfile object without sanitizing input, a maliciously crafted .tar file could perform a directory path traversal attack. We found at least one unsantized extractall() in your codebase and are providing a patch for you via pull request. The patch essentially checks to see if all tarfile members will be extracted safely and throws an exception otherwise. We encourage you to use this patch or your own solution to secure against CVE-2007-4559. Further technical information about the vulnerability can be found in this blog.

If you have further questions you may contact us through this projects lead researcher Kasimir Schulz.

RKrahl commented 1 year ago

Many thanks for your effort to check this repository!

However, in this particular case, this is not an issue. The extractall() calls are in the test suite. They are applied to trusted tar files with well known content: the tar files are created by the test suite itself. All members in these tar files are known to have sane paths.